Alexander Aring wrote:
> u8 head[100] = {};

What I mean is: I don't see the original code doing a memset on
"head", so I'm a bit puzzled why you have to do this now.

Was the original code broken by not zeroing "head" ? If yes,
that would be a bug fix, not a mere optimization.

Or did I overlook something ?

> It's ugly to make the 100 byte magic number here, what we need is a
> number MAX_LOWPAN_HEADER_LENGTH.

Yeah, since you have that evil [100] in the patch, it will draw
attention :)

- Werner

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to