Hi Werner,
2013/7/24 Werner Almesberger <wer...@almesberger.net>
> Alexander Aring wrote:
> > u8 head[100] = {};
>
> What I mean is: I don't see the original code doing a memset on
> "head", so I'm a bit puzzled why you have to do this now.
>
> Was the original code broken by not zeroing "head" ? If yes,
> that would be a bug fix, not a mere optimization.
>
> You are right, we set each inline data and we doesn't care if it already
zero or something. I will change that to the old behavior.
But to set the ipv6 struct to zero makes sense. Then we don't need to set
the traffic class to zero when we need it set to zero or the uncompression
of addresses. The old code calculates are interval between the pre and
postfix of inline data and run a memset zero on it.
Or did I overlook something ?
>
> No, I overlook something, we don't need it in the header create part, sry
:-)
> > It's ugly to make the 100 byte magic number here, what we need is a
> > number MAX_LOWPAN_HEADER_LENGTH.
>
>
I will try to calculate this number. I have some 6lowpan lecture which I
can confirm this number, or this number stands in some rfc's, I will take a
look.
Yeah, since you have that evil [100] in the patch, it will draw
> attention :)
>
>
Thanks for your reply.
- Alex
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
