On Wed, Aug 07, 2013 at 04:22:17PM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > When we set it to zero, we can assume that the memory is already zero > > while parsing. > > > > Also remove some code to set mem regions to zero. > > Looks good. From your description it's not obvious why you removed the > zeroing of the memory region. I'd mention that the memset operated on > fields of "hdr", which are now assured to be zero. > Ok, sry.
> It would also be good if you could briefly classify the patch. E.g., > this one would be a code simplification (and not a bug fix, feature > addition, optimization, etc.) > Yea, the next patch for the new uncompression functions don't set the memory to zero depends on this patch. But you are right, it doesn't fix any bug. I will try to change it. I don't want to calculate little tiny intervalls and then run memset on it or call memset(&hdr.saddr...0, 16) before uncompression. Thanks ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
