Alexander Aring wrote: > For other context based address we print a warning and drop the package
Packet ? :-) > + if (iphc1 & LOWPAN_IPHC_SAC) { > + /* Source address context based uncompression */ > + pr_debug("SAC bit is set. Handle context based source > address.\n"); > + err = lowpan_uncompress_context_based_src_addr( > + skb, &hdr.saddr, tmp); > + if (err) > + goto drop; > + } else { > + /* Source address uncompression */ > + pr_debug("source address stateless compression\n"); > + err = lowpan_uncompress_addr(skb, &hdr.saddr, tmp, _saddr); > + if (err) > + goto drop; > + } You could make this a single error check by moving it after the end of the if-else. Besides that, looking good as well. Also the patches I haven't commented on look good. - Werner ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel