Hi,

On Fri, Aug 09, 2013 at 01:05:19PM +0400, Alexander Smirnov wrote:
> 2013/8/9 Alexander Aring <alex.ar...@gmail.com>
> 
> > Version 2 of "address uncompress fix" series.
> > Please review.
> >
> > v2:
> >  - add patch "add function to uncompress multicast addr"
> >  - fix length check in uncompression address functions
> >  - handle error handling after branch in patch
> >    "handle context based source address"
> >  - add more information in commit message of patch
> >    "init ipv6hdr buffer to zero"
> >
> > Alexander Aring (6):
> >   6lowpan: init ipv6hdr buffer to zero
> >   6lowpan: handle only real local link addresses
> >   6lowpan: introduce lowpan_fetch_skb function
> >   6lowpan: add function to uncompress multicast addr
> >   6lowpan: lowpan_uncompress_addr with address_mode
> >   6lowpan: handle context based source address
> >
> > David Hauweele (1):
> >   6lowpan: Fix fragmentation with link-local compressed addresses
> >
> >
> Please do not mix fixes and new features in a single series. Fixes can be
> applied to a current kernel tree while new features only to next.
> 
These fix-patches depends on the new features. I don't know how I need
to handle that.

I determine "new feature" patches to:
"6lowpan: init ipv6hdr buffer to zero"
"6lowpan: introduce lowpan_fetch_skb function"

a middle thing is:
"6lowpan: handle context based source address"

It's maybe a new feature because we handle the unspec address or maybe a
fix because we never handled it. :)


So "6lowpan: introduce lowpan_fetch_skb function" I can do the old thing
like in patch series v1. We discussed this in the last mail of patch
series v1...

The Patch "6lowpan: lowpan_uncompress_addr with address_mode" is also a fix
and new feature. It's drops complete the crazy hard to understand pre- and
postcount calculation which is not maintainable. 
In the current uncompress address function do many things which aren't correct,
according to rfc 6282. It's completly broken, only global link address
works correctly (I suppose).

- Alex

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel

Reply via email to