Hi Alex, On Wed, Aug 14, 2013 at 03:23:48PM +0400, Alexander Smirnov wrote: > On 08/14/2013 03:01 PM, Alexander Aring wrote: > >The current implementation to uncompress addresses in a 6lowpan header > >is completely broken. > > > >This patch series fixes the parsing of addresses in a 6lowpan header. > >It contains a major rewrite of the uncompress address function to parse > >the address in a correct way. > > > > Could you please describe in a few words how have you tested the changes? >
I test this with a ravenusbstick and the jackdaw firmware. This is a usb stick with a contiki stack which offers a ipv6 interface under linux. It still uses the 6LoWPAN contiki stack. On the other side I have a beaglebone device with the current net-next 6LoWPAN stack. I add several addresses to this linux device to catch all cases (except short address) in the uncompression function. With a ping6 $ADDRESS and wireshark on the usb stick I see the outcomming 6lowpan packets. If I get a correct reply with the used address it seems that the uncompression works. I am thinking to implement some test cases to test all uncompression of all address-cases. This patch series was tested manually. A wireshark on the beaglebone doesn't work at the moment. I get a nullpointer dereference in the 6LoWPAN stack. I suppose this is why the 6LoWPAN Stack copies sk_buffs and free the old one. This is a wrong behaviour because the caller of a function has the old sk_buff which is freed. I need some time to drop the skb_clone functions.... and then I will check wireshark. If wireshark works I don't see the 6LoWPAN Header anyway, but I can see if the ipv6 header is reconstructed correctly. > Small cosmetic hint: lowpan_raw_dump_inline() already has an > argument to print debug message, so there is no need to add extra > pr_debug calls before it to print static text. > ok, I will change it. Regards Alex ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
