Hi Werner, On Mon, Oct 14, 2013 at 08:36:57PM -0300, Werner Almesberger wrote: > Alexander Aring wrote: > > This is necessary for upcomming patches to calculate the 6lowpan header. > > Maybe explain a bit more what you're doing ? I.e., that - if I > understand correctly - you're now making use of skb->transport_header > and skb->network_header to keep track of things, which the old code > didn't do. > That's only a little hint that you can't assume that the transport header is there because sometimes the transport header is compressed in the network header. (That's some kind of 6LoWPAN magic there)...
> > For now it's okay to make it in this way, because we use this to calculate > > the 6lowpan header size only. > > I only understand about half of what you're doing here, but I'll > give your the benefit of the doubt ;-) > For fragmentation we need the length of the network header, means the 6lowpan header size. When we set this we can use: lowpan_size = skb->transport_header - skb->network_header; This patch only preparing it that we can do that. The alternative would be to set it in skb_cb, that was the old behaviour. Maybe I should set it in the skb_cb, or not? Some notice: We can do the lowpan_size calculation of course when the transport_header is compressed in the 6LoWPAN header. - Alex ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
