Alexander Aring wrote:
> I don't know which version you using, but checkpatch --strict seems fine
> for this change.
>
> I using Version: 0.32 from net-next.
Me too :)
% md5sum scripts/checkpatch.pl
cfb469de383b64f47e13351c8f8bb577 scripts/checkpatch.pl
% md5sum net/ieee802154/6lowpan.c
c12ee1d69ae93cb8d39ba00eff144cb9 net/ieee802154/6lowpan.c
That's 6lowpan.c from b45bd46decd947eaa3497699d450e0851d247534
after applying only the whitespace patch.
scripts/checkpatch.pl -f --strict net/ieee802154/6lowpan.c
yields the complaints below.
- Werner
---------------------------------- cut here -----------------------------------
CHECK: Alignment should match open parenthesis
#140: FILE: ieee802154/6lowpan.c:140:
+lowpan_compress_addr_64(u8 **hc06_ptr, u8 shift, const struct in6_addr *ipaddr,
+ const unsigned char *lladdr)
CHECK: Alignment should match open parenthesis
#169: FILE: ieee802154/6lowpan.c:169:
+lowpan_uncompress_addr(struct sk_buff *skb,
+ struct in6_addr *ipaddr,
CHECK: Alignment should match open parenthesis
#205: FILE: ieee802154/6lowpan.c:205:
+ memcpy(&ipaddr->s6_addr[8], lladdr->hwaddr,
+ IEEE802154_ADDR_LEN);
CHECK: Alignment should match open parenthesis
#240: FILE: ieee802154/6lowpan.c:240:
+ lowpan_raw_dump_inline(NULL, "Reconstructed ipv6 addr is:\n",
+ ipaddr->s6_addr, 16);
CHECK: Alignment should match open parenthesis
#250: FILE: ieee802154/6lowpan.c:250:
+lowpan_uncompress_context_based_src_addr(struct sk_buff *skb,
+ struct in6_addr *ipaddr,
CHECK: Alignment should match open parenthesis
#273: FILE: ieee802154/6lowpan.c:273:
+ lowpan_raw_dump_inline(NULL,
+ "Reconstructed context based ipv6 src addr is:\n",
CHECK: Alignment should match open parenthesis
#284: FILE: ieee802154/6lowpan.c:284:
+lowpan_uncompress_multicast_daddr(struct sk_buff *skb,
+ struct in6_addr *ipaddr,
CHECK: Alignment should match open parenthesis
#331: FILE: ieee802154/6lowpan.c:331:
+ lowpan_raw_dump_inline(NULL, "Reconstructed ipv6 multicast addr is:\n",
+ ipaddr->s6_addr, 16);
CHECK: Alignment should match open parenthesis
#496: FILE: ieee802154/6lowpan.c:496:
+ lowpan_raw_dump_table(__func__, "raw skb network header dump",
+ skb_network_header(skb), sizeof(struct ipv6hdr));
CHECK: Alignment should match open parenthesis
#528: FILE: ieee802154/6lowpan.c:528:
+ if (((hdr->flow_lbl[0] & 0x0F) == 0) &&
+ (hdr->flow_lbl[1] == 0) && (hdr->flow_lbl[2] == 0)) {
CHECK: Alignment should match open parenthesis
#532: FILE: ieee802154/6lowpan.c:532:
+ if ((hdr->priority == 0) &&
+ ((hdr->flow_lbl[0] & 0xF0) == 0)) {
CHECK: Alignment should match open parenthesis
#543: FILE: ieee802154/6lowpan.c:543:
+ if ((hdr->priority == 0) &&
+ ((hdr->flow_lbl[0] & 0xF0) == 0)) {
CHECK: Alignment should match open parenthesis
#661: FILE: ieee802154/6lowpan.c:661:
+ lowpan_raw_dump_table(__func__, "raw skb data dump", skb->data,
+ skb->len);
CHECK: Prefer kzalloc(sizeof(*frame)...) over kzalloc(sizeof(struct
lowpan_fragment)...)
#770: FILE: ieee802154/6lowpan.c:770:
+ frame = kzalloc(sizeof(struct lowpan_fragment),
CHECK: Alignment should match open parenthesis
#827: FILE: ieee802154/6lowpan.c:827:
+ lowpan_raw_dump_table(__func__, "raw skb data dump", skb->data,
+ skb->len);
WARNING: quoted string split across lines
#855: FILE: ieee802154/6lowpan.c:855:
+ pr_debug("%s received a FRAG1 packet (tag: %d, "
+ "size of the entire IP packet: %d)",
WARNING: quoted string split across lines
#861: FILE: ieee802154/6lowpan.c:861:
+ pr_debug("%s received a FRAGN packet (tag: %d, "
+ "size of the entire IP packet: %d, "
WARNING: quoted string split across lines
#880: FILE: ieee802154/6lowpan.c:880:
+ pr_debug("%s first fragment received for tag %d, "
+ "begin packet reassembly", __func__, tag);
CHECK: Alignment should match open parenthesis
#889: FILE: ieee802154/6lowpan.c:889:
+ skb_copy_to_linear_data_offset(frame->skb, offset * 8,
+ skb->data, skb->len);
CHECK: Alignment should match open parenthesis
#897: FILE: ieee802154/6lowpan.c:897:
+ if ((frame->bytes_rcv == frame->length) &&
+ frame->timer.expires > jiffies) {
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
#897: FILE: ieee802154/6lowpan.c:897:
+ frame->timer.expires > jiffies) {
WARNING: quoted string split across lines
#904: FILE: ieee802154/6lowpan.c:904:
+ pr_debug("%s successfully reassembled fragment "
+ "(tag %d)", __func__, tag);
CHECK: braces {} should be used on all arms of this statement
#997: FILE: ieee802154/6lowpan.c:997:
+ if ((iphc0 & 0x03) != LOWPAN_IPHC_TTL_I)
[...]
+ else {
[...]
CHECK: Alignment should match open parenthesis
#1068: FILE: ieee802154/6lowpan.c:1068:
+ lowpan_raw_dump_table(__func__, "raw UDP header dump",
+ (u8 *)&uh, sizeof(uh));
CHECK: Alignment should match open parenthesis
#1120: FILE: ieee802154/6lowpan.c:1120:
+lowpan_fragment_xmit(struct sk_buff *skb, u8 *head,
+ int mlen, int plen, int offset, int type)
CHECK: Alignment should match open parenthesis
#1143: FILE: ieee802154/6lowpan.c:1143:
+ skb_copy_from_linear_data_offset(skb, offset + mlen,
+ skb_put(frag, plen), plen);
WARNING: quoted string split across lines
#1196: FILE: ieee802154/6lowpan.c:1196:
+ pr_debug("%s unable to send a subsequent FRAGN packet "
+ "(tag: %d, offset: %d", __func__, tag, offset);
CHECK: Prefer kzalloc(sizeof(*entry)...) over kzalloc(sizeof(struct
lowpan_dev_record)...)
#1382: FILE: ieee802154/6lowpan.c:1382:
+ entry = kzalloc(sizeof(struct lowpan_dev_record), GFP_KERNEL);
total: 0 errors, 6 warnings, 22 checks, 1525 lines checked
net/ieee802154/6lowpan.c has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
