On Tue, May 15, 2007 at 12:28:55PM +0200, Peter Stuge wrote:
> On Tue, May 15, 2007 at 10:26:54AM +0000, [EMAIL PROTECTED] wrote:
> > static inline int spd_read_byte(unsigned device, unsigned address)
> > {
> > - uint8_t c;
> > - c = smbus_read_byte(device, address);
> > - return c;
> > + return smbus_read_byte(device, address);
>
> Should they return uint8_t perhaps?Yes, I think so. AFAIK smbus works with byte values (or at least smbus_read_byte() does), and SPD data consists of bytes, too... Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list [email protected] http://www.linuxbios.org/mailman/listinfo/linuxbios
