> Comments welcome, of course.
Well you asked for it :-)
> +/ {
> + model = "StorCenter";
If you can find a real model number, put it in here,
instead.
> + compatible = "storcenter";
Needs a manufacturer name in there.
> + PowerPC,603e { /* Really 8241 */
So say "PowerPC,[EMAIL PROTECTED]", or "PowerPC,[EMAIL PROTECTED]" (or whatever
the CPU core in there is), or simply "[EMAIL PROTECTED]", following
the generic naming recommended practice.
> + bus-frequency = <0>;
Is this filled in anywhere? Please document that, if so.
> + /* Following required by dtc but not used */
> + i-cache-line-size = <0>;
> + d-cache-line-size = <0>;
> + i-cache-size = <4000>;
> + d-cache-size = <4000>;
Not used _by the Linux kernel_, it's required by the
PowerPC binding. Perhaps that should be modified
for flat device tree use, there are many more required
properties that no flat tree has anyway.
> + [EMAIL PROTECTED] {
> + device_type = "rom";
I'm sure you know I find this "rom" binding to be crap.
However, I didn't yet write up the "cfi" binding, so I
can't complain ;-)
> + partitions = <
> + 00000000 0000E000
> + 0000E000 00002000
> + 00010000 00040000
> + 00050000 00200000
> + 00250000 004B0000
> + 00700000 00020000
> + 00720000 00010000
> + 00730000 00010000
> + 00740000 000B0000
> + >;
Nothing from 7f0000 to 7fffff?
> + soc10x {
Bad name. Where is the binding for this? I don't think
I saw it before.
> + compatible = "mpc10x";
"manufacturer,106-host" or similar. But this isn't an 10x
at all, is it?
> + store-gathering = <0>; /* 0 == off, !0 == on */
Don't define this as "!0", but as "1".
> + [EMAIL PROTECTED] {
> + device_type = "i2c";
No device_type, there is no I2C binding.
> + compatible = "fsl-i2c";
Needs to be more specific.
> + mpic: [EMAIL PROTECTED] {
[EMAIL PROTECTED]
> + #interrupt-cells = <2>;
> + #address-cells = <0>;
No #address-cells here.
> + device_type = "open-pic";
device_type = "interrupt-controller" I believe, unless
the mpic binding does something weird.
> + [EMAIL PROTECTED] {
> + clock-frequency = <d# 100000000>; /* Hz */
100MHz PCI? Interesting.
> + interrupt-map = <
> + /* IDSEL 0x15 - ETH */
> + 7800 0 0 1 &mpic 0 1
7800 isn't device 0x15. I think you meant 15.
Segher
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
