ext Brian King wrote:
> +
> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + struct ibmveth_adapter *adapter = dev->priv;
> +
Why do not to do
if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum))
return 0;
less two lines.
> + if (data && adapter->rx_csum)
> + return 0;
> + if (!data && !adapter->rx_csum)
> + return 0;
> +
> + return ibmveth_set_csum_offload(dev, data, ibmveth_set_rx_csum_flags);
> +}
> +
> +static int ibmveth_set_tx_csum(struct net_device *dev, u32 data)
> +{
> + struct ibmveth_adapter *adapter = dev->priv;
> + int rc = 0;
> +
here also, as above ...
> + if (data && (dev->features & NETIF_F_IP_CSUM))
> + return 0;
> + if (!data && !(dev->features & NETIF_F_IP_CSUM))
> + return 0;
> +
> + if (data && !adapter->rx_csum)
> + rc = ibmveth_set_csum_offload(dev, data,
> ibmveth_set_tx_csum_flags);
> + else
> + ibmveth_set_tx_csum_flags(dev, data);
> +
> + return rc;
> +}
> +
Best regards,
Ragner
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
