On Jul 23, 2007, at 8:48 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2007-07-23 at 15:50 -0500, Kumar Gala wrote:
>> --- a/arch/powerpc/sysdev/mpic.c
>> +++ b/arch/powerpc/sysdev/mpic.c
>> @@ -836,6 +836,7 @@ static struct irq_chip mpic_irq_chip = {
>> .mask = mpic_mask_irq,
>> .unmask = mpic_unmask_irq,
>> .eoi = mpic_end_irq,
>> + .end = mpic_unmask_irq,
>> .set_type = mpic_set_irq_type,
>> };
>
> Nope, that doesn't look correct and shouldn't be in this patch in the
> first place.
>
> end() is flow control business, not chip business, so it's really
> something that needs to be fixed in the fasteoi handler for -rt I
> suppose.
Ok, I dropped this one for now.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
