Olof Johansson wrote: > On Thu, Jul 26, 2007 at 11:25:04PM +0200, Marian Balakowicz wrote: >> >> Olof Johansson wrote: >>> Move away from using the pci config access functions for simple register >>> access. Our device has all of the registers in the config space (hey, >>> from the hardware point of view it looks reasonable :-), so we need to >>> somehow get to it. Newer firmwares have it in the device tree such that >>> we can just get it and ioremap it there (in case it ever moves in future >>> products). For now, provide a hardcoded fallback for older firmwares. >> I have recently tried to apply a group of your MAC patches that >> includes the one from this email. Strangely, I got a pretty random >> kernel panics (or kernel freezes) when this patch is included. Panics >> happen in a random, places and have random causes. What I observed is >> that replacing newly introduced mac->iob_regs with the corresponding >> offset from (already ioremapped) hose->cfg_data removed the problem. So, >> it seems that dereferencing pointers based on a second ioremap on a >> subset of 0xe000_0000 addresses is problematic. > > The problem is that the IOB register range is 8K, not 4K. I have since > fixed that bug but I didn't repost the patch series. It does cause weird > and strange errors to happen since register writes into the second 4K > would really go to another mapping somewhere else. > > So, the quick fix is to always map 0x2000 in map_one_reg, the slightly better > one is to check the PCI dev and only map 2K for the IOB.
Thanks for the pointer. Using 0x2000 for IOB solves the problem. Regards, Marian _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
