On Wed, 15 Aug 2007 17:53:00 +0400 Valentine Barshak <[EMAIL PROTECTED]> wrote:
> David Gibson wrote: > >> diff -ruN linux-2.6.orig/arch/powerpc/kernel/head_44x.S > >> linux-2.6/arch/powerpc/kernel/head_44x.S > >> --- linux-2.6.orig/arch/powerpc/kernel/head_44x.S 2007-08-14 > >> 17:11:19.000000000 +0400 > >> +++ linux-2.6/arch/powerpc/kernel/head_44x.S 2007-08-14 > >> 17:18:43.000000000 +0400 > >> @@ -217,7 +217,7 @@ > >> lis r4,[EMAIL PROTECTED] /* IVPR only uses the high 16-bits */ > >> mtspr SPRN_IVPR,r4 > >> > >> -#ifdef CONFIG_440EP > >> +#if defined(CONFIG_440EP) || defined(CONFIG_440EPX) > > > > Since we should now be able to support both 440GP and 440EP boards in > > the same kernel, this probably needs to become a feature section. > > > > Thanks for pointing that out. > Talking about this, there appears to be more stuff that would need to > become feature sections. There're lots of other ifdefs in > arch/powerpc/kernel/head_44x.S, like ifdef CONFIG_PPC_FPU or ifdef > CONFIG_440A > Looks like all these things have to be detected dynamically and > configured properly at runtime since we tend to support more than one > CPU in the same kernel. Yes, definitely. It's on my TODO list. The "multiplatformness" of 44x at the moment needs work. > I think this should come as a separate patch, that replaces all these > ifdefs with the FTR_SECTION stuff. I agree. I'd like to do this as a separate patch later rather than hold up Sequoia at the moment. josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
