Steven Rostedt <rost...@goodmis.org> writes: > On Wed, 22 Feb 2017 00:31:01 +0530 > "Naveen N. Rao" <naveen.n....@linux.vnet.ibm.com> wrote: > >> entry_*.S now includes a lot more than just kernel entry/exit code. As a >> first step at cleaning this up, let's split out the ftrace bits into >> separate files. Also move all related tracing code into a new trace/ >> subdirectory. >> >> No functional changes. > > I wonder if we should stay consistent among archs, and call these files > "mcount_*.S". Or perhaps we should change x86 from mcount_64.S to > ftrace_64.S?
I prefer ftrace_64.S, there's a lot more in those files than just the mcount() implementation, and it also makes the link to kernel/trace/ftrace.c more obvious. I don't know if it's really worth keeping the names the same across arches, especially as we already have: arch/arm64/kernel/entry-ftrace.S arch/arm/kernel/entry-ftrace.S arch/blackfin/kernel/ftrace-entry.S arch/metag/kernel/ftrace_stub.S But we can rename it if you feel strongly about it. cheers
