Arnd Bergmann wrote: > On Tuesday 12 February 2008, David Gibson wrote: >> Or to expand. It's relatively easy now to just include multiple nodes >> in the tree and either delete or nop some of them out conditionally >> using libfdt.
Yes, but what better place to store the conditions than in the device tree itself? How would libfdt know where the conditions are? Do you want to have two binary blobs? >> But the conditional logic should be in the manipulating >> agent (u-boot or bootwrapper or whatever), there's no way we're going >> to require a conditional expression parser to interpret the device >> tree blob itself. I think it's a great feature that solves a lot of problems, and it does so in an elegant and efficient manner. I look forward to trying to change your mind when I get around to implementing it. > How about making the logic to nop out nodes a little more generic > without changes to the binary format? > E.g. you could have a "linux,conditional-node" property in the device > tree whose value is compared to a HW configuration specific string. The problem with this is that if you use a version of libfdt that does not understand "linux,conditional-node", then your device tree will be wrong, because it could contain nodes that don't belong. We would need a new, incompatible version number for the device tree to make sure that this doesn't happen, even though nothing has changed in the binary layout of the tree. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
