On Jun 3, 2008, at 10:10 AM, Scott Wood wrote:

Kumar Gala wrote:
How is this as a fix.
- k
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/ platforms/85xx/Kconfig
index 7ff29d5..9e5c884 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -34,6 +34,7 @@ config MPC85xx_MDS
        bool "Freescale MPC85xx MDS"
        select DEFAULT_UIMAGE
        select QUICC_ENGINE
+       select PHYLIB if GIANFAR=m
        help
          This option enables support for the MPC85xx MDS board

I assume you'll also ifdef-protect the phy calls in the platform code?

yes this needs to get done.

I'd rather avoid adding another case where the kernel needs to know what modules are being built, though, especially if the result of changing the .config and building modules is a mysterious runtime failure (due to a missing platform fixup) rather than compile- or insertion-time.

I don't follow what you are getting at here. Is this something more than #ifdef PHYLIB in the platform code?

- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to