Hi Mark On Mon, Feb 9, 2026 at 11:16 AM Shengjiu Wang <[email protected]> wrote: > > On Fri, Feb 6, 2026 at 10:37 PM Mark Brown <[email protected]> wrote: > > > > On Fri, Feb 06, 2026 at 04:43:33PM +0800, Shengjiu Wang wrote: > > > > > + SOC_ENUM("Transmit Timestamp Increment", tstmp_enum[0]), > > > > Don't have arrays of enums with magic indexes into them - this is just > > error prone and hard to follow. The normal thing is to declare a > > separtae variable for each enum, or if you *must* use an array use > > named constants at both ends to index into it (but that's not > > meaningfully different to just having multiple variables...). > > Thanks for the comments. I will update it. > > > > > > + SOC_SINGLE("Transmit Timestamp Reset", FSL_SAI_TTCTL, > > > __bf_shf(FSL_SAI_xTCTL_RTSC), 1, 0), > > > + SOC_SINGLE("Transmit Bit Counter Reset", FSL_SAI_TTCTL, > > > __bf_shf(FSL_SAI_xTCTL_RBC), 1, 0), > > > > __bf_shf()? > > Can we use the __bf_shf() to get the shift of the mask?
Shall I use the definition FSL_SAI_xTCTL_RBC_SHIFT to replace __bf_shf(FSL_SAI_xTCTL_RBC)? Best regards Shengjiu Wang > > best regards > Shengjiu Wang
