[PATCH net] net: wan: fsl_ucc_hdlc: return NETDEV_TX_OK if skb was freed

[Holger Brunck]

If the skb was freed in the ucc_hdlc_tx function and the packet marked
as dropped we need to return NETDEV_TX_OK. Otherwise the above layer
will try to requeue an already freed skb.

Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
Signed-off-by: Holger Brunck <holger.bru...@hitachienergy.com>
---
 drivers/net/wan/fsl_ucc_hdlc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index 7af558780bdc..6ce539151618 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.c
+++ b/drivers/net/wan/fsl_ucc_hdlc.c
@@ -360,7 +360,7 @@ static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct 
net_device *dev)
                        dev->stats.tx_dropped++;
                        dev_kfree_skb(skb);
                        netdev_err(dev, "No enough space for hdlc head\n");
-                       return -ENOMEM;
+                       return NETDEV_TX_OK;
                }
 
                skb_push(skb, HDLC_HEAD_LEN);
@@ -377,7 +377,7 @@ static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct 
net_device *dev)
                        dev->stats.tx_dropped++;
                        dev_kfree_skb(skb);
                        netdev_err(dev, "Wrong ppp header\n");
-                       return -ENOMEM;
+                       return NETDEV_TX_OK;
                }
 
                dev->stats.tx_bytes += skb->len;
@@ -390,7 +390,7 @@ static netdev_tx_t ucc_hdlc_tx(struct sk_buff *skb, struct 
net_device *dev)
        default:
                dev->stats.tx_dropped++;
                dev_kfree_skb(skb);
-               return -ENOMEM;
+               return NETDEV_TX_OK;
        }
        netdev_sent_queue(dev, skb->len);
        spin_lock_irqsave(&priv->lock, flags);
-- 
2.47.3