> > On Mon, 4 May 2026 19:44:06 +0200 Holger Brunck wrote: > > If the skb was freed in the ucc_hdlc_tx function and the packet marked > > as dropped we need to return NETDEV_TX_OK. Otherwise the above layer > > will try to requeue an already freed skb. > > Is this really true? I thought negative returns mean drop.
the API suggest to only use NETDEV_TX_OK or NETDEV_TX_BUSY as return value. I checked several drivers and they are usually returning NETDEV_TX_OK if an error occurred and the driver consumed the packet. But you are right dev_xmit_complete will also return true if the return code is smaller than zero and the packet is not requeued. Should I update the commit message or should the patch be dropped? Best regards Holger
