Re: [PATCH v1 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets

[Peter Zijlstra]

On Tue, May 05, 2026 at 02:16:23PM +0530, Sathvika Vasireddy wrote:
>       switch (opcode) {
> +     case 16:

Like case 18 below, this wants a comment describing which instruction
this is; bclr ?

> +             if (ins & 1)
> +                     typ = INSN_OTHER;
> +             else
> +                     typ = INSN_JUMP_CONDITIONAL;
> +             imm = ins & 0xfffc;
> +             if (imm & 0x8000)
> +                     imm -= 0x10000;
> +             insn->immediate = imm | aa;
> +             break;
> +
>       case 18: /* b[l][a] */
>               if (ins == 0x48000005)  /* bl .+4 */
>                       typ = INSN_OTHER;