On Tue, May 05, 2026 at 04:45:39PM +0200, Peter Zijlstra wrote:
> On Tue, May 05, 2026 at 02:16:23PM +0530, Sathvika Vasireddy wrote:
> > switch (opcode) {
> > + case 16:
>
> Like case 18 below, this wants a comment describing which instruction
> this is; bclr ?
Also, isn't that typically used for return, suggesting at least
something should have INSN_RETURN on?
> > + if (ins & 1)
> > + typ = INSN_OTHER;
> > + else
> > + typ = INSN_JUMP_CONDITIONAL;
> > + imm = ins & 0xfffc;
> > + if (imm & 0x8000)
> > + imm -= 0x10000;
> > + insn->immediate = imm | aa;
> > + break;
> > +
> > case 18: /* b[l][a] */
> > if (ins == 0x48000005) /* bl .+4 */
> > typ = INSN_OTHER;
