On Mon, Oct 20, 2008 at 11:32 PM, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Mon, 2008-10-20 at 22:05 +0000, Linux Kernel Mailing List wrote: >> Gitweb: >> http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0c5d1eb77a8be917b638344a22afe1398236482b >> Commit: 0c5d1eb77a8be917b638344a22afe1398236482b >> Parent: d6d5aeb661fc14655c417f3582ae7ec52985d2a8 >> Author: David Brownell <[EMAIL PROTECTED]> >> AuthorDate: Wed Oct 1 14:46:18 2008 -0700 >> Committer: Ingo Molnar <[EMAIL PROTECTED]> >> CommitDate: Thu Oct 2 10:24:09 2008 +0200 > > This one is obviously broken and breaks booting on a whole bunch of > machines (including powermac's and thus my G5, it's never good when my > own machine breaks !). > > Nice to see 3 SOB's and one Ack and nobody caught the obvious bug :-) > >> desc = irq_desc + irq; >> - if (desc->chip->set_type) { >> - spin_lock_irqsave(&desc->lock, flags); >> - ret = desc->chip->set_type(irq, type); >> - spin_unlock_irqrestore(&desc->lock, flags); >> - } >> + if (type == IRQ_TYPE_NONE) >> + return 0; >> + >> + spin_lock_irqsave(&desc->lock, flags); >> + ret = __irq_set_trigger(desc, irq, flags); > ^^^^ type maybe ? > >> + spin_unlock_irqrestore(&desc->lock, flags); >> return ret; >> } > > I have to run so no patch until tomorrow unless somebody beats me to it.
there is patch about it, but somehow get lost. YH _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
