On 2026/07/12 05:13 PM, Thorsten Blum wrote: > The local table structure is not used - remove it. > > Remove % in the comment while at it. > > Signed-off-by: Thorsten Blum <[email protected]> > --- > arch/powerpc/platforms/ps3/spu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/powerpc/platforms/ps3/spu.c > b/arch/powerpc/platforms/ps3/spu.c > index e817def7f424..c904f9fa1caa 100644 > --- a/arch/powerpc/platforms/ps3/spu.c > +++ b/arch/powerpc/platforms/ps3/spu.c > @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu) > * The current HV requires the spu shadow regs to be mapped with the > * PTE page protection bits set as read-only. > * > - * Returns: %0 on success or -errno on error. > + * Returns: 0 on success or -errno on error.
The % prefix should actually be kept here I think. Per the kernel-doc documentation [1]: %CONST Name of a constant. (No cross-referencing, just formatting.) Examples: %0 %NULL %-1 %-EFAULT %-EINVAL %-ENOMEM So %0 is valid and intentional kernel-doc markup that renders the constant 0 with proper formatting. The struct removal part looks good though. [1]: https://docs.kernel.org/doc-guide/kernel-doc.html#highlights-and-cross-references ~Amit > */ > > static int __init setup_areas(struct spu *spu) > { > - struct table {char* name; unsigned long addr; unsigned long size;}; > - > spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr, > sizeof(struct spe_shadow), > > pgprot_noncached_wc(PAGE_KERNEL_RO));
