On Mon, Jul 13, 2026 at 01:59:02PM +0530, Amit Machhiwal wrote: > On 2026/07/12 05:13 PM, Thorsten Blum wrote: > > The local table structure is not used - remove it. > > > > Remove % in the comment while at it. > > > > Signed-off-by: Thorsten Blum <[email protected]> > > --- > > arch/powerpc/platforms/ps3/spu.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/arch/powerpc/platforms/ps3/spu.c > > b/arch/powerpc/platforms/ps3/spu.c > > index e817def7f424..c904f9fa1caa 100644 > > --- a/arch/powerpc/platforms/ps3/spu.c > > +++ b/arch/powerpc/platforms/ps3/spu.c > > @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu) > > * The current HV requires the spu shadow regs to be mapped with the > > * PTE page protection bits set as read-only. > > * > > - * Returns: %0 on success or -errno on error. > > + * Returns: 0 on success or -errno on error. > > The % prefix should actually be kept here I think. Per the kernel-doc > documentation [1]: > > %CONST > Name of a constant. (No cross-referencing, just formatting.) > > Examples: > > %0 %NULL %-1 %-EFAULT %-EINVAL %-ENOMEM > > So %0 is valid and intentional kernel-doc markup that renders the > constant 0 with proper formatting.
Interesting - not sure I have seen this style before and plain 0 seems to be far more common. There has been some discussion around it here: https://lore.kernel.org/all/[email protected]/ I guess I'll send a v2 without the %0 change. Thanks, Thorsten
