From: bui duc phuc <[email protected]>
snd_pcm_hw_constraint_integer() may return 1, which is then returned
from acp_dma_open(). ASoC only marks the component as opened when
.open() returns 0, so .close() can be skipped on rollback.
Return 0 explicitly on success.
Fixes: 623621a9f9e1 ("ASoC: amd: Add common framework to support I2S on ACP
SOC")
Reviewed-by: Vijendar Mukunda <[email protected]>
Signed-off-by: bui duc phuc <[email protected]>
---
sound/soc/amd/acp/acp-platform.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 6b1e18b31c1c..f2c8853775ad 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -248,7 +248,12 @@ static int acp_dma_open(struct snd_soc_component
*component, struct snd_pcm_subs
list_add_tail(&stream->list, &chip->stream_list);
spin_unlock_irq(&chip->acp_lock);
- return ret;
+ /*
+ * ASoC only marks the component as opened when .open() returns 0.
+ * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
+ * return 0 to ensure .close() is not skipped on rollback.
+ */
+ return 0;
}
static int acp_dma_hw_params(struct snd_soc_component *component,
--
2.43.0
