From: bui duc phuc <[email protected]>
snd_pcm_hw_constraint_integer() may return 1, which is then returned
from acp5x_dma_open(). ASoC only marks the component as opened
when .open() returns 0, so .close() can be skipped on rollback.
Return 0 explicitly on success.
Fixes: cab396d8b22c ("ASoC: amd: add ACP5x pcm dma driver ops")
Reviewed-by: Vijendar Mukunda <[email protected]>
Signed-off-by: bui duc phuc <[email protected]>
---
sound/soc/amd/vangogh/acp5x-pcm-dma.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c
b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
index 831e30e9b042..72050fa2de80 100644
--- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c
+++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c
@@ -231,7 +231,13 @@ static int acp5x_dma_open(struct snd_soc_component
*component,
}
i2s_data->acp5x_base = adata->acp5x_base;
runtime->private_data = i2s_data;
- return ret;
+
+ /*
+ * ASoC only marks the component as opened when .open() returns 0.
+ * Since snd_pcm_hw_constraint_integer() may return 1, explicitly
+ * return 0 to ensure .close() is not skipped on rollback.
+ */
+ return 0;
}
static int acp5x_dma_hw_params(struct snd_soc_component *component,
--
2.43.0
