Segher Boessenkool wrote: >> + If you say yes to this option, support will be included for the >> + USB Gecko adapter as an udbg console. >> + The USB Gecko is a EXI to USB Serial converter that can be plugged >> + into a memcard slot in the Nintendo GameCube/Wii. > > Not "a" memcard slot, only the first one, you have it hardcoded. >
No. It's not hardcoded in the code. It's specified in the device tree source. The hardcoded one is just the early udbg, not the "normal" udbg. >> +#if 0 >> +/* >> + * Trasmits a null terminated character string. >> + */ >> +static void ug_puts(char *s) >> +{ >> + while (*s) >> + ug_putc(*s++); >> +} >> +#endif > > Remove? > Ok :) >> + stdout = of_find_node_by_path(path); >> + if (!stdout) { >> + udbg_printf("%s: missing path %s", __func__, path); >> + goto done; >> + } >> + >> + for (np = NULL; >> + (np = of_find_compatible_node(np, NULL, "usbgecko,usbgecko"));) >> + if (np == stdout) >> + break; >> + >> + of_node_put(stdout); >> + if (!np) { >> + udbg_printf("%s: stdout is not an usbgecko", __func__); >> + goto done; >> + } > > Surely there is something called something like of_node_is_compatible() > you can use here? You already have the node pointer, there is no need > to look at all other nodes. > I see the point. I didn't find of_node_is_compatible() but I'll look what's available here. Thanks, Albert _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev