On Oct 14, 2011, at 1:31 PM, Hans J. Koch wrote: > On Thu, Oct 13, 2011 at 10:50:58AM -0500, Kumar Gala wrote: >> From: Kai Jiang <kai.ji...@freescale.com> >> >> To support >32-bit physical addresses for UIO_MEM_PHYS type we need to >> extend the width of 'addr' in struct uio_mem. Numerous platforms like >> embedded PPC, ARM, and X86 have support for systems with larger physical >> address than logical. >> >> Since 'addr' may contain a physical, logical, or virtual address the >> easiest solution is to just change the type to 'phys_addr_t' which >> should always be greater than or equal to the sizeof(void *) such that >> it can properly hold any of the address types. >> >> For physical address we can support up to a 44-bit physical address on a >> typical 32-bit system as we utilize remap_pfn_range() for the mapping of >> the memory region and pfn's are represnted by shifting the address by >> the page size (typically 4k). >> >> Signed-off-by: Kai Jiang <kai.ji...@freescale.com> >> Signed-off-by: Minghuan Lian <minghuan.l...@freescale.com> >> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> > > Signed-off-by: "Hans J. Koch" <h...@hansjkoch.de> > > That looks good to me. There's an unnecessary cast (see below), but I fixed > that > on the way. > > Greg, please pull this from branch uio-for-gregkh from > > git://hansjkoch.de/git/linux-hjk > > Thanks, > Hans
I think removing that cast is wrong: drivers/uio/uio.c: In function 'uio_vma_fault': drivers/uio/uio.c:637:26: warning: cast to pointer from integer of different size - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
