On Tue, Jan 24, 2012 at 2:38 PM, Rob Herring <robherri...@gmail.com> wrote:
> On 01/23/2012 03:07 PM, Grant Likely wrote:
>> Part of the series to unify the irq remapping mechanisms in the
>> kernel. A follow up patch will copy the powerpc implementation into
>> kernel/irq/irqdomain.c, which will be a lot easier if the structures
>> are identical.
>>
>> Where they differ, I've chose to use the powerpc names since there is
>> a lot more code using those names.
>>
>> Signed-off-by: Grant Likely <grant.lik...@secretlab.ca>
>> ---
>> arch/arm/common/gic.c | 14 ++++----
>> include/linux/irqdomain.h | 84
>> ++++++++++++++++++++++++++++++++++-----------
>> kernel/irq/irqdomain.c | 14 ++++----
>> 3 files changed, 78 insertions(+), 34 deletions(-)
>>
>
> snip...
>
>> @@ -126,7 +126,7 @@ void irq_dispose_mapping(unsigned int irq)
>> }
>> EXPORT_SYMBOL_GPL(irq_dispose_mapping);
>>
>> -int irq_domain_simple_dt_translate(struct irq_domain *d,
>> +int irq_domain_simple_xlate(struct irq_domain *d,
>> struct device_node *controller,
>> const u32 *intspec, unsigned int intsize,
>> unsigned long *out_hwirq, unsigned int *out_type)
>
> This needs a declaration in irqdomain.h (as well as EXPORT?). There
> could be others as well, but this is the one I'm using for generic irq chip.
Fine by me. I'll add that as a follow-on patch since nothing in-tree
currently depends on that. It will be in the next version of the
patch series. Also, are you okay if I rename it to
irq_domain_generic_xlate()? Simple doesn't really describe it well,
and it can be used for any interrupt controller implementing the
binding we've settled on as recommended for new device support.
g.
>
> Rob
>
>> @@ -181,7 +181,7 @@ EXPORT_SYMBOL_GPL(irq_domain_generate_simple);
>>
>> struct irq_domain_ops irq_domain_simple_ops = {
>> #ifdef CONFIG_OF_IRQ
>> - .dt_translate = irq_domain_simple_dt_translate,
>> + .xlate = irq_domain_simple_xlate,
>> #endif /* CONFIG_OF_IRQ */
>> };
>> EXPORT_SYMBOL_GPL(irq_domain_simple_ops);
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
