On Thu, 30 Jul 2015, Vlastimil Babka wrote:

> --- a/mm/slob.c
> +++ b/mm/slob.c
>       void *page;
>
> -#ifdef CONFIG_NUMA
> -     if (node != NUMA_NO_NODE)
> -             page = alloc_pages_exact_node(node, gfp, order);
> -     else
> -#endif
> -             page = alloc_pages(gfp, order);
> +     page = alloc_pages_node(node, gfp, order);

NAK. This is changing slob behavior. With no node specified it must use
alloc_pages because that obeys NUMA memory policies etc etc. It should not
force allocation from the current node like what is happening here after
the patch. See the code in slub.c that is similar.

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to