On Mon, 2015-11-23 at 12:45 +0300, Denis Kirjanov wrote: > On 11/23/15, Michael Ellerman <m...@ellerman.id.au> wrote: > > Hi Denis, > > > > On Fri, 2015-11-20 at 17:48 +0300, Denis Kirjanov wrote: > > > Hi guys, > > > > > > As we all know we have a great tool to track the patch queue - patchwork. > > > The sad thing is that it's maintained not good as it could be. The > > > netdev patchwork is a great example of how it can be done and I bet > > > everyone would love to see the ppc patch queue like that. > > > > What exactly is wrong with it? > > I just wanted to point out that we have some patches without any reply like > https://patchwork.ozlabs.org/patch/518981/ or patches since 2010.
OK. 518981 was part of a big series adding that stuff to lots of drivers. I was waiting to see if someone was picking up the whole series, or if I was expected to. I'll put those in this merge window. It's true we have some old stuff lying around. Some of them are things we still mean to look at, but just haven't had time, and others are just old junk that we never get around to. I generally work from the top of the list and never get to the bottom :) And most of those old patches are delegated to Benh & Scottwood anyway ;) > > > So can we improve the current situation? I'd love to help in any way > > > possible. > > > > You could send fewer patches ;) > > I could, but I want make it better :) Yeah that was a bit sarcastic of me :) The main thing you could do, and anyone could do (!), is just review some patches. Even if you don't know the area of code that well, you can usually do a basic review. eg. Just the basic stuff: - Is the subject correctly formatted and makes sense. - Is the change log well written and describes the change well. - Does the patch do one logical change. - Are there any obviously bad coding style things. - Can you follow the basics of the change based on the change log and some reading of the code? Another thing I seem to spend a lot of time on is asking people if their patch should go to stable or not, and if so what versions. So everyone could help out there. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
