On Oct 29, 2006, at 5:10 PM, Nicolas DET wrote: > This patch add MPC52xx Interrupt controller for ARCH=powerpc. > > It includes the main code in arch/powerpc/sysdev/ ad well as an > header file in > include/asm-powerpc. > > Signed-off-by: Nicolas DET <[EMAIL PROTECTED]>
Can you see if you can figure out how to inline patches with your mailer, its really difficult to comment on issues w/an attachment. +/* MBAR position */ +#define MPC52xx_MBAR 0xf0000000 /* Phys address */ +#define MPC52xx_MBAR_VIRT 0xf0000000 /* Virt address */ +#define MPC52xx_MBAR_SIZE 0x00010000 + +#define MPC52xx_PA(x) ((phys_addr_t)(MPC52xx_MBAR + (x))) +#define MPC52xx_VA(x) ((void __iomem *)(MPC52xx_MBAR_VIRT + (x))) This should be handled dynamically (pulled from the device tree), I doubt MBAR will be at the same location for all boards. * can you split out the interrupt controller header info into a mpc52xx_pic.h [mpc52xx_intr, MPC52xx_IRQ_...] * lets drop all the other struct defn in mpc52xx.h. This is a hold over from arch/ppc and we really should only put defn that we actually need closer to the code that uses them (ie, drivers, etc.) - kumar _______________________________________________ Linuxppc-embedded mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-embedded
