Kumar Gala wrote:
On Oct 29, 2006, at 5:10 PM, Nicolas DET wrote:
This patch add MPC52xx Interrupt controller for ARCH=powerpc.
It includes the main code in arch/powerpc/sysdev/ ad well as an header
file in
include/asm-powerpc.
Signed-off-by: Nicolas DET <[EMAIL PROTECTED]>
Can you see if you can figure out how to inline patches with your
mailer, its really difficult to comment on issues w/an attachment.
OT:
Well, on a personal point of view, the only usable mailer I know does
not run on my 'work' OS. I'll copy/paste from an editor ;-)
+/* MBAR position */
+#define MPC52xx_MBAR 0xf0000000 /* Phys address */
+#define MPC52xx_MBAR_VIRT 0xf0000000 /* Virt address */
+#define MPC52xx_MBAR_SIZE 0x00010000
+
+#define MPC52xx_PA(x) ((phys_addr_t)(MPC52xx_MBAR + (x)))
+#define MPC52xx_VA(x) ((void __iomem *)(MPC52xx_MBAR_VIRT + (x)))
This should be handled dynamically (pulled from the device tree), I
doubt MBAR will be at the same location for all boards.
Well, 0xf000000 seems some kind of 'standart' value. we could have a
global variable 'mpc52xx_mbar' which would be default 0xf0000000 and
modified by each platform.
* can you split out the interrupt controller header info into a
mpc52xx_pic.h [mpc52xx_intr, MPC52xx_IRQ_...]
Well, I dod personally have the whole structure/define in a single
header rather than splitting in xxx files.
begin:vcard
fn:Nicolas DET ( bplan GmbH )
n:DET;Nicolas
org:bplan GmbH
adr:;;;;;;Germany
email;internet:[EMAIL PROTECTED]
title:Software Entwicklung
tel;work:+49 6171 9187 - 31
x-mozilla-html:FALSE
url:http://www.bplan-gmbh.de
version:2.1
end:vcard
_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded
