On 11/1/06, Nicolas DET <[EMAIL PROTECTED]> wrote:
> Grant Likely wrote:
> > As part of the transition to arch/powerpc, this patch moves the mpc5200 PSC
> > driver over to the OF platform bus infrastructure.
> >
> > This patch is not acceptable for mainline as-is because it breaks arch/ppc
> > support for the mpc52xx. More rework is needed to allow it to compile for
> > either arch (or alternately, fork the driver)
> >
>
> It has been hard to apply on 2.6.19-rc4 but it seems to perform well.
> I add to add some entries in mpc52xx_uart_match[]
Good news, thanks for the feedback. I take it you are able to use the
serial port with this driver?
>
> In now looks like this:
> static struct of_device_id mpc52xx_uart_match[] = {
> {
> .name = "serial",
> .compatible = "mpc52xx-psc",
> },
> {
> .name = "serial",
> .compatible = "mpc52xx-serial",
> },
> {
> .name = "serial",
> .compatible = "mpc5200-psc",
> },
> {
> .name = "serial",
> .compatible = "mpc5200-serial",
> },
> {},
> };
I'd rather not do this for the mainline code. I'd rather define a
naming convention and all of us use it. We're early enough in this
process that we can do that since there are only two major boards
(lite5200 & Efika) on track to be supported in mainline ATM.
Having 4 compatibility blocks to support 2 boards is over-engineering. :)
>
> By the way, why not using mpc52xx_uart_match[] to also in
> mpc52xx_console_setup() to track down any devices?
Because I hadn't thought of that, and therefore have not decided if
that's a good idea! :) I'll take a look.
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
[EMAIL PROTECTED]
(403) 399-0195
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded
