On Wed, Sep 07, 2005 at 08:42:42PM -0400, Dan Malek wrote: > > On Sep 7, 2005, at 8:28 PM, Benjamin Herrenschmidt wrote: > > >I'm not fan of the approach. You should use in_/out_ macros for IOs. If > >you don't need eieio on 8xx , then just #ifdef it out of the > >implementation of these. > > Yeah, #ifdef :-) That patch wouldn't go anywhere (well, > to /dev/null perhaps).
Well, its easy to s/st/out/ - s/ld/in/, so its still a useful patch. ;) > We can just use the in_/out_ macros that are there. The eieio > doesn't hurt anything on the 8xx. eieio/isync are not required. There's no need to execute redudant instructions and occupy kernel space.
