On Fri, Feb 21, 2014 at 10:40:55AM +0100, dbrign...@audioscience.com wrote:
> From: Delio Brignoli <dbrign...@audioscience.com>
>
> When peer delay is < min_neighbor_prop_delay the port is flagged
> as non 802.1AS capable. min_neighbor_prop_delay defaults to INT_MIN.
>
> Signed-off-by: Delio Brignoli <dbrign...@audioscience.com>
> ---
>
> Changes since v1:
> * limit INT32_MIN <= min_neighbor_prop_delay <= -1
> so we are sure that min_neighbor_prop_delay < neighborPropDelayThresh
> * change type of min_neighbor_prop_delay from Integer32 to int
>
> config.c | 6 ++++++
> ds.h | 1 +
> port.c | 11 +++++++++++
> ptp4l.8 | 4 ++++
> ptp4l.c | 2 ++
> 5 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/config.c b/config.c
> index cfe36b8..78f1655 100644
> --- a/config.c
> +++ b/config.c
> @@ -125,6 +125,12 @@ static enum parser_result parse_pod_setting(const char
> *option,
> return r;
> pod->neighborPropDelayThresh = uval;
>
> + } else if (!strcmp(option, "min_neighbor_prop_delay")) {
> + r = get_ranged_int(value, &val, INT32_MIN, -1);
Nit picking:
Here we want INT_MIN (no 32), and then it looks good to go.
Thanks,
Richard
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
