On 21 Feb 2014, at 12:48, Richard Cochran <richardcoch...@gmail.com> wrote:
> On Fri, Feb 21, 2014 at 11:32:27AM +0100, Delio Brignoli wrote: >> Hello Miroslav, >> >> On 21 Feb 2014, at 11:20, Miroslav Lichvar <mlich...@redhat.com> wrote: >>> On Fri, Feb 21, 2014 at 10:40:55AM +0100, dbrign...@audioscience.com wrote: >>>> From: Delio Brignoli <dbrign...@audioscience.com> >>>> >>>> When peer delay is < min_neighbor_prop_delay the port is flagged >>>> as non 802.1AS capable. min_neighbor_prop_delay defaults to INT_MIN. >>> >>>> config.c | 6 ++++++ >>>> ds.h | 1 + >>>> port.c | 11 +++++++++++ >>>> ptp4l.8 | 4 ++++ >>>> ptp4l.c | 2 ++ >>>> 5 files changed, 24 insertions(+), 0 deletions(-) >>> >>> Can you please also add the new option to default.cfg and gPTP.cfg? >> >> Do we need to do that? The default value (set in ptp4l.c) means this option >> is disabled and I do not think many people will want to use it. I would argue >> that it adds noise to the default configuration files, but if the >> policy is that every option has to be present in default configuration files >> I will add it. Opinions? > > If this option is somehow useful for gPTP applications, then I think > it should at least appear in gPTP.cfg. > > Also, on second thought, maybe INT_MIN is too extreme as a default > value. Since the default neighborPropDelayThresh is 20ms, maybe using > something like -20ms is more balanced. I mean, the propagation delay > cannot possibly get so far out, can it? No, it can hardly be as low in practice but I was actually thinking the opposite: we should increase neighborPropDelayThresh to INT32_MAX. I mean, why the half hearted attempt at disabling the option when we can ensure it never triggers? Also 20ms is really a number I came up with because is large enough, but it’s not specified anywhere. — Delio ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
