On Wed, May 07, 2014 at 06:23:15PM +0200, Jiri Benc wrote:
> Add automatic configuration option (-a).
This seems to be working, but only when phc2sys is running for short
time. If it runs for more than few minutes, it seems to stop reacting
to port state changes.
>
> Signed-off-by: Jiri Benc <jb...@redhat.com>
> ---
> phc2sys.c | 265
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++----
> 1 files changed, 250 insertions(+), 15 deletions(-)
> +static int do_loop(struct node *node, int subscriptions)
> @@ -483,18 +557,34 @@ static int do_loop(struct node *node)
>
> while (1) {
> clock_nanosleep(CLOCK_MONOTONIC, 0, &interval, NULL);
> - do_leap = update_sync_offset(node);
> + do_leap = update_pmc(node, 0);
Shouldn't the second parameter be "subscriptions > 0"?
Also, are you planning to implement some check that would abort/reinit
phc2sys when ptp4l is killed (update_pmc fails to update the UTC
offset or the resubscription fails)? I'm worried it's too easy to get
into a state where phc2sys is not receiving updates and the user is
wondering why it's not working as expected.
Thanks,
--
Miroslav Lichvar
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
