On Mon, 12 May 2014 17:25:51 +0200, Miroslav Lichvar wrote: > On Wed, May 07, 2014 at 06:23:15PM +0200, Jiri Benc wrote: > > + do_leap = update_pmc(node, 0); > > Shouldn't the second parameter be "subscriptions > 0"?
Yes. Seems it got incorrect during rework of the "Subscription time limit" patch and apparently I haven't tested the new version long enough (unlike the original version). I'll fix it, thanks for catching this. > Also, are you planning to implement some check that would abort/reinit > phc2sys when ptp4l is killed (update_pmc fails to update the UTC > offset or the resubscription fails)? I'm worried it's too easy to get > into a state where phc2sys is not receiving updates and the user is > wondering why it's not working as expected. Yes. I have it on a todo list but as the problem exists with the current code, too (albeit it's much less visible) I don't consider it to be part of this set. Jiri -- Jiri Benc ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
