> -----Original Message----- > From: Jiri Benc [mailto:jb...@redhat.com] > Sent: Wednesday, December 10, 2014 12:11 AM > To: Delio Brignoli > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH RFC 0/4] Time stamp asymmetry > correction > > On Mon, 8 Dec 2014 14:04:56 +0100, Delio Brignoli wrote: > > Yes, I was thinking it would allow to query if the driver supports this > > feature and get/set current offsets. > > I agree. That way, with correctly implemented drivers the user will > get the right correction for free but will be still able to overrule > the values. > > What I'm thinking of is having an ethtool operation to get/set > ingress/egress correction. This will be handled in the kernel (i.e. not > propagated to the drivers to prevent misuse). The driver provides > initial correction values (or zero if they're unknown) but user space > is free to alter them or reset them to the initial values. It is > obviously per-interface setting. > > A nice bonus is this will work with all program using the time stamping > interface, not just linuxptp. > > This is compatible with Richard's patchset, only the config options > would call the ethtool op instead of doing the correction in ptp4l. > > Jiri > > --
I really like this idea. Done in the kernel, but allow driver to initiate correct values if necessary. It does need to support link speeds somehow so that change in link speed gets the correct values. Not 100% sure the best way to handle link speeds, but definitely would be better to do this in kernel. Regards, Jake ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
