On Mon, Apr 23, 2018 at 09:06:48AM +0000, Anders Selhammer wrote:
> Friday, April 20, 2018 6:09 PM
> 
> -     p->dscmp = dscmp;
> +     if (config_get_int(cfg, NULL, "dataset_comparison") == DS_CMP_G8275) {
> +             p->dscmp = telecom_dscmp;
> +     } else {
> +             p->dscmp = dscmp;
> +     }
> 
> This should not be needed if port get the comparation function from clock.

Right, I'll refactor that.

> Added that in my version "v2 2/7] clock: Added getter for dscmp configured 
> for the clock"

Sorry for not making this clear, but I am going to merge *my* patch
series from 2017, once it is ready.  You can't expect to simply
re-write existing code in a different way and expect that to be
merged.  You series also lacks proper change log messages.  Also, I
put a fair amount of testing into my 2017 series, but yours is brand
new.

Thanks,
Richard



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to