> -----Original Message-----
> From: Geva, Erez [mailto:[email protected]]
> Sent: Tuesday, June 11, 2019 7:32 AM
> To: Petr Machata <[email protected]>
> Cc: [email protected]
> Subject: Re: [Linuxptp-devel] [PATCH v2] sk: Recognize HWTSTAMP_FILTER_SOME
>
> If you ask to stamp all packets with HWTSTAMP_FILTER_ALL, then you can not
> get a
> reply of "plus some others".
> You ask for all, which more do you think you can get?
>
> It does make sense as a reply in case of HWTS_FILTER_FULL.
>
I assume you mean "does not" here.
> enum hwtstamp_rx_filters {
> /* time stamp any incoming packet */
> HWTSTAMP_FILTER_ALL,
>
> As of HWTS_FILTER_NORMAL case, your patch make sense.
>
Yea, for the HWTS_FILTER_FULL case, we request _ALL, which means that a value
of _SOME shouldn't really be returned, because that would not cover the _ALL
case. There are no other packets beyond _ALL, so returning _SOME doesn't make
sense.
Regards,
Jake
> Thanks
> Erez
>
>
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
