On Thu, 18 Jun 2020 at 23:02, Jacob Keller <jacob.e.kel...@intel.com> wrote: > > > > On 6/18/2020 12:56 PM, Vladimir Oltean wrote: > >> Could this use the pr facility, so that it honors the printing options > >> to log to syslog and manages the level? > >> > >> I'm not sure what I would mark these as: debug because they no longer > >> impact the syncing process, or true error because they are unexpected? > >> > >> Thanks, > >> Jake > >> > > > > Thanks a lot for looking at this. > > Good point about redirecting to syslog, I did not think about that. > > The reason why I did not use pr_err was due to the automatic line > > ending, which would have unnecessarily complicated this function by > > having me print each line of the packet to a temporary buffer first. > > But now that I see there's no way around it, I guess I'll have to do > > that. > What about implementing this as part of pr.c? > > Thanks, > Jake
Not really sure what you mean. What would the prototype of the function be (i.e. what would it do)? -Vladimir _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
