On Fri, Jun 19, 2020 at 02:55:17PM +0300, Vladimir Oltean wrote: > Sure. In fact, printing the data on the error queue is totally > optional and I could just as well remove it, no problem with that. But > reading it isn't. I don't think you've addressed that point.
Yes, here, for correctness sake, the program should be robust to POLLERR being set unexpectedly. I don't know of any situation that would set POLLERR on the kind of sockets in use here, but even so, this is a generic flag that might appear one day. But the patch does not handle the situation correctly. This code would dump the frame and carry on as if nothing had happened. The correct way would be to treat this as a fault on the port in question. Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
