On Wed, Nov 11, 2020 at 10:43:40AM -0800, Jacob Keller wrote:
> Ok, so now the node/agent tracks the subscriptions automatically. So
> someone else needs to call renew_subscription first.

Right, actually the user needs to call pmc_agent_subscribe()...
 
> Patch context alone isn't enough to follow where that happens.

... which is called in auto_init_ports() in phc2sys.c.

> We pass
> subscriptions to do_loop. Is this still used? No longer necessary? hmm.

Yes, the main phc2sys logic uses that flag here:

        while (is_running()) {
                ...

                if (subscriptions) {
                        run_pmc_events(priv->node);
                        if (priv->state_changed) {
                                /* force getting offset, as it may have
                                 * changed after the port state change */
                                if (pmc_agent_query_utc_offset(priv->node, 
1000)) {
                                        pr_err("failed to get UTC offset");
                                        continue;
                                }
                                reconfigure(priv);
                        }
                }
                ...
        }

Thanks,
Richard


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to