On Sat, Nov 14, 2020 at 10:48:01PM +0200, Vladimir Oltean wrote: > Do you know exactly why we retrieve the UTC offset implicitly and not > explicitly, considering that phc2sys already calls run_pmc_get_utc_offset > enough times directly already?
The caller asks for the UTC offset explicitly at the beginning and after a change in port state. The offset does not change very often, at most once every six months. However, it does change, and so the client has to check once in a while. > > + * - Any active port state subscription will be renewed. > > + * - The port state notification callback might be invoked. > > Which one is that? You mean ->recv_subscribed? Yes. > "Might" be called? That's the best we can say right now, right. Asking > "why" it would be called might be too deep of a question. Right, the callback happens if - the port state push notification arrives, and - a callback was registered in the first place. > > + * Note that the PMC agent rate limits the query to once per minute. > > Somehow the description doesn't say the most important thing from a user > perspective. Could you please mention that this needs to be called > periodically to avoid expiry of the subscription? Maybe move this > comment from where it is right now: The UTC offset is not subscribed. It is polled with a request/reply once a minute. (Only the port state has a push notification.) Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
