On Tue, May 04, 2021 at 04:43:51PM +0900, 박웅섭 wrote: > 1.In the text->length=c->desc.userDescription.length part of clock.c line > 368, the length declared in the static_ptp_text structure is of type signed > int and the length declared in the text structure is unsigned int. Why did > you write the code like this? Assigning Signed integers to unsigned > integers can lead to overflow problems.
In my copy of the code the length field of the PTPText structure is uint8_t. It's a structure used in the network protocol. > 2. The memcpy function is vulnerable to security. Wouldn't it be correct to > use memcpy_s instead of memcpy function? Isn't that a Windows-only function? -- Miroslav Lichvar _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
