On Fri, May 07, 2021 at 11:37:06AM +0000, Amar Subramanyam wrote: > Continuous BMCA triggering in port 2 causes a SYNCHRONIZATION FAULT in > port1.This causes port1 to jump from SLAVE to UNCALIBRATED and vice versa > repeatedly.
I'm sorry if I sound like a broken record, but what exactly is the cause of the fault? Is it the clock check seeing timestamps from two clocks that are not synchronized? Do the faults disappear if you set --sanity_freq_limit=0? That's the only fault I see in my test and in your original report. Your patch doesn't seem to prevent that fault in my test, so I'm confused. > Noted. Please find the updated description and function name below, we will > send out the modified patch after full review. > > + * Get port SLAVE state for client only mode. > + * @param c The clock instance. > + * @return Return 0 if any port is in SLAVE state, 1 otherwise. > + */ > +int clock_get_port_slave_state(struct clock *c); There might be a better name for this function. Maybe something related to its purpose rather than what it does. > Hence, we are clearing the Announce receipt timer for port2 (LISTENING port) > in the function bc_event() upon Announce receipt timeout, only when > boundary_clock_jbod=1 and clientOnly=1 is configured and atleast one port > (Port1 here) is in SLAVE/UNCALIBRATED state. Ok, but if this optimization is useful in the jbod mode, it should be useful even in the non-jbod mode, right? Most of the port code shouldn't care about jbod. -- Miroslav Lichvar _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
