On Thu, 20 Jan 2022 at 12:52, Miroslav Lichvar <mlich...@redhat.com> wrote:
> On Thu, Jan 20, 2022 at 11:24:59AM +0000, Geva, Erez wrote: > > Hi, > > > > When we would use multiple PHC per interface (or per bridge/switch). > > How can we defer a real PHC from virtual PHC? > > I think you would need to iterate over all interfaces and find the one > which has the vclock, and then get the index of its real PHC. > I meant that I think we should add a flag indicating the PHC is virtual as we can use a PHC index for a real PHC of multiple PHCs, or one created for VLAN over bond. And we might have more kinds in the future. > > > Would not it be easier to simply call then multiple PHC and use the > index regardless if it is virtual or not. > > I'm not sure to what exactly you are referring to, but in the patches > I sent we need to know whether it's a virtual clock in order to bind > the sockets. > > Yap, but we should bare in mind that multiple PHC indexes could be a real PHC or other kind, so we should probably use a flag to indicate the PHC index is a virtual if we need to defar on the socket layer (sk.c). > > As for the PORT_PROPERTIES_NP. It is a port TLV not a clock TLV. > > With the jbod option each port can have a different PHC. > Yap, but it could have multiple clocks (though not on the same PTP domain). I think we need to support both. Multiple real PHC on a single interface is not here yet, but I do not see the big difference to multiple virtual PHCs. At the end it is only if the Hardware has the PHC or there is a software implementing it. > > > I think it is better to add a new TLV and not break backward compatible > of PORT_PROPERTIES_NP. > > A patch like that was rejected 2 month ago. > > Ok. > Cool :-) > > Thanks, > > -- > Miroslav Lichvar > > > Erez > > _______________________________________________ > Linuxptp-devel mailing list > Linuxptp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linuxptp-devel >
_______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
